ssl parameter name confusion

[apeeters]

The parameters used to configure the ssl certificate used by puppetboard mention puppetdb in their name:

• puppetdb_key
• puppetdb_cert
• puppetdb_ssl_verify

However, these should contain the path to puppetboard-specific key and cert. Hence I propose to rename them in accordance with the puppetlabs/puppetdb module:

• ssl_key_path
• ssl_cert_path

The final parameter (puppetdb_ssl_verify) might be split to improve its meaning, however this is also caused by puppetboard itself.

• ssl_ca_cert_path
• ssl_verify

[apeeters]

Relates to #94.

[wyardley]

Sounds like this was closed in #99

[apeeters]

@wyardley please consider reopening the issue: I believe the original proposal regarding parameter names is still valid.

[ffrank]

@apeeters are you working on a patch, or are you waiting for peer feedback?

@wyardley why is this labelled as "skip changelog"? I feel that a change like this should absolutely be logged.

Are we looking at a breaking change, or would you deprecate the old parameters gracefully?

[wyardley]

@ffrank I can add it back; sometimes we try to skip older issues in the changelog if they're still open, since it might cause confusion.

[wyardley]

@ffrank but keep in mind that any actual change to the code would have a PR that would show up in the changelog.

[ffrank]

Uh, I think I'm rather confused about the semantics of that label. I thought it would lead to a possible fix being omitted from the change log? If that's not the case, it's probably wrong to remove it after all 😅

Thanks for the feedback!