Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh #3

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Add refresh #3

merged 1 commit into from
Nov 14, 2017

Conversation

raphink
Copy link
Member

@raphink raphink commented Aug 22, 2017

This adds refresh support to the puppet_certificate type, allowing certificates to be recreated when triggered by another resource.

An example of usage is to regenerate certificates when the csr_attributes.yaml file is modified:

    file { "${confdir}/puppet/csr_attributes.yaml":
      ensure  => file,
      owner   => 'root',
      group   => 'root',
      mode    => '0440',
      content => template('blah/csr_attributes.yaml.erb'),
    }
    ~> puppet_certificate { $certname:
      ensure               => present,
      waitforcert          => 60,
    }

@raphink
Copy link
Member Author

raphink commented Nov 13, 2017

@reidmv did you have a chance to look at this?

@reidmv
Copy link
Member

reidmv commented Nov 13, 2017

@raphink Looking now. There's no description in the PR and no description in the commit message for what this is used for... Can you describe the use case? What is this for? Would be good to have that information in the commit message as well so our future selves have a reminder about why this change was made.

@raphink
Copy link
Member Author

raphink commented Nov 13, 2017

@reidmv added a description to the PR.

@raphink raphink mentioned this pull request Nov 13, 2017
@reidmv reidmv merged commit 221ea79 into voxpupuli:master Nov 14, 2017
reidmv added a commit that referenced this pull request Nov 14, 2017
@reidmv
Copy link
Member

reidmv commented Nov 14, 2017

@raphink awesome, thanks! Sorry I didn't see these PRs earlier.

I've merged this (and #4, and #5) in a work branch, made one change (safeguard the refresh functionality behind an onrefresh parameter), updated the README to reflect the changes, and then merged the entire work branch into master.

Can you take a look at the master branch and see if I managed to incorporate everything sanely? If it looks good let me know and I'll cut a new version/release.

Thanks for your work on this!!!

@raphink
Copy link
Member Author

raphink commented Nov 14, 2017

Thanks for merging @reidmv . I'll have to rebase my code on it and check that every thing is fine, but it looks good to me already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants