Document PE workaround for auth.conf #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
reviewed
Jul 21, 2023
Co-authored-by: Kenyon Ralph <[email protected]>
kenyon
approved these changes
Jul 21, 2023
alexjfisher
reviewed
Jul 27, 2023
| @@ -105,6 +105,35 @@ Example auth.conf rule: | |||
| } | |||
| ``` | |||
|
|
|||
| Puppet Enterprise already has a rule for this API. You cannot have multiple | |||
| blocks in auth.conf for the same path. Therefor you need to patch | |||
There was a problem hiding this comment.
Suggested change
| blocks in auth.conf for the same path. Therefor you need to patch | |
| blocks in auth.conf for the same path. Therefore you need to patch |
alexjfisher
reviewed
Jul 27, 2023
| match_request_method => ['get','put','delete'], | ||
| - allow => $_client_allowlist << $ca_cli_extension, | ||
| + allow => ['$1', $_client_allowlist].flatten << | ||
| $ca_cli_extension, |
There was a problem hiding this comment.
With this (accidental?) line break, I think this diff is broken?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues