Composer #656
Open
Composer #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
reviewed
Mar 9, 2022
root-expert
requested changes
Apr 11, 2022
There was a problem hiding this comment.
Hello @kapouik ,
can we get some basic unit tests for this change?
root-expert
added
backwards-incompatible
enhancement
initial test for composer
added 2 commits
May 1, 2022 18:24
initial test for composer
|
I have prepare basic test : It only check if composer is installed from default fact. As other test, I can add check if other channel work if I change it. If you have other idea ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
By default, when the module install composer, it use https://getcomposer.org/composer.phar
It install the latest preview from nighty build of the dev main repository.
I have set a case that allow to download the right version of composer depending from the channel selected. By default, it use the latest stable.
This Pull Request (PR) fixes the following issues
No issue