[warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in [from nginx 1.25.1 onwards]

[xepa]

In version 1.25.1 and later http2 directive in listen statement is deprecated, the current method should only change operations if the version of nginx is 1.25.1 or later (older versions MUST retain this method).

For reference please see https://nginx.org/en/docs/http/ngx_http_v2_module.html#http2

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: all
• Ruby: all
• Distribution: all
• Module version:

How to reproduce (e.g Puppet code you use)

nginx::resource::server { 'example.com':
  ssl            => true,
  http2       => true,
  ... and others ...
}

What are you seeing

# MANAGED BY PUPPET
server {
  listen       *:443 ssl http2;
  ... and others ...
}

What behaviour did you expect instead

# MANAGED BY PUPPET
server {
  listen       *:443 ssl;
  http2        on;
  ... and others ...
}

Output log

2024/05/08 12:34:46 [warn] 2465396#2465396: the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/sites-enabled/100-sentry.veaplatform.nl_https.conf:4

Any additional information you'd like to impart

[TheMeier]

Hm isn't that already implemented

puppet-nginx/templates/server/server_ssl_settings.erb

Lines 4 to 6 in 7f3a8ae

	<% if scope.call_function('versioncmp', [scope['nginx::nginx_version'], '1.25.1']) >= 0 && @http2 -%>
	http2 <%= @http2 %>;
	<% end -%>

[TheMeier]

I guess the issue is, last release was Jun 26, 2023

[xepa]

I was not aware that this was even an option, not sure why my code is even doing this I will investigate .. I will reopen if I can not get this to work ..

[TheMeier]

As I pointed out, that feature is not released :/

[999faryad]

Problem still occurs in the latest version. also with
http2 => 'on',

[999faryad]

@xepa since you have not reopened the issue, have you found a workaround / fix?

[kenyon]

@999faryad it was fixed in #1579, but there hasn't been a release containing this yet. You can use the module from git instead of a release.

[xepa]

@xepa since you have not reopened the issue, have you found a workaround / fix?

I was using the master ..