Fix: do not print properies if they are absent. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous check was wrong because the "provider.send(propery)" returns a string and was always true.
|
Good catch! Dis this take into account the fact that absent could also be a symbol? |
|
I thinks "absent" cant never be a value for address, netmask or mtu, that's why I discarted it. |
provider,options can also be absent, so it has to be checked.
adrienthebo
added a commit
that referenced
this pull request
Feb 4, 2015
Fix: do not print properies if they are absent.
|
Thanks! |
jordiclariana
pushed a commit
to trovitsys/puppet-network
that referenced
this pull request
Mar 19, 2015
Fix: do not print properies if they are absent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check was wrong because the "provider.send(propery)" returns a string and was always true.