Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let travis call rake spec with the proper LOAD_PATH set. #108

Closed
wants to merge 6 commits into from
Closed

Let travis call rake spec with the proper LOAD_PATH set. #108

wants to merge 6 commits into from

Conversation

JimPanic
Copy link
Contributor

This is the same fix for master as for 0.4.x.

@adrienthebo
Copy link
Member

This build failed, and if this needs to be done in multiple places then perhaps it's being fixed at the wrong layer. Could this be fixed in spec_helper.rb instead?

@JimPanic
Copy link
Contributor Author

There are two different cases of failure:

  • Puppet 4 + Ruby 1.8 (I'm not sure how to fix this yet)
  • failing tests - hey, at least the tests actually run now :)

This is the same place as in the 0.4.x branch, but the travis.yml was updated since then and the tests are now invoked differently (bundle exec rake spec instead of spec/travis_rspec.rb). I think the two failures require a PR each on their own.

@JimPanic
Copy link
Contributor Author

I also tried fixing it in spec_helper.rb but to no avail…

@JimPanic
Copy link
Contributor Author

Closing this in favour of two other PRs #109 #110

@JimPanic JimPanic closed this Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants