-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 0.5.x in the puppet-community namespace #106
Conversation
We need to move to metadata.json before this can be released I'm pretty sure. |
I'm all for that! |
I don't have access to the puppet-community namespace, so you guys are on your own for releasing this. Godspeed! |
Here's a basic |
#114 is what we need to be able to travis-deploy |
ff8a444
to
cce9127
Compare
Any ideas on how to supply Travis with augeas? |
Well I tried that one thing.... |
@nibalizer use your words, dude. |
I tried https://github.com/puppet-community/puppet-network/pull/114/files setting sudo to true and adding some install agueas apt get commands. Doesn't seem to have worked. |
@DavidS can you help us get these tests passing? |
Commented on #114. Looks good, I think with the Will try that here later. |
Or @adrienthebo? You had those tests passing somewhere, right? I'd like to run them at home, but I'm currently having fun with my pre-packaged Ruby 2.1 barfing severely upon the |
It seems to fail on requiring augeas >= 0.10 in the kmod module. Have you tried adding the ruby-augeas gem or stubbing $::augeasversion? |
any news here? |
This should be the same fix that dom advised for another PR. |
@ffrank wanna rebase this? |
@ffrank wanna rebase this, so we can release? :D |
Thanks for the reminder. Will look into it next chance. |
Merge and release away. |
Release version 0.5.x in the puppet-community namespace
@ffrank hm… that didn't create a tag… |
No this doesn't create a tag. You have to create the tag and push it in. |
TIL :/ |
current status: 🔥 💻 💥
ping @carlossg |
I guess you just need a |
That should be provided by the blacksmith thingy if it depends on it. |
actually what you need to include is
|
Currently includes the 0.4.2 patch. Once we agreed on that one, we should merge it back up and rebase this one.
With the changelog, I erred on the side of verbosity.