Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.5.x in the puppet-community namespace #106

Merged
merged 2 commits into from
Aug 13, 2015

Conversation

ffrank
Copy link
Contributor

@ffrank ffrank commented Jun 16, 2015

Currently includes the 0.4.2 patch. Once we agreed on that one, we should merge it back up and rebase this one.

With the changelog, I erred on the side of verbosity.

@nibalizer
Copy link
Member

We need to move to metadata.json before this can be released I'm pretty sure.

@ffrank
Copy link
Contributor Author

ffrank commented Jun 17, 2015

I'm all for that!

@adrienthebo
Copy link
Member

I don't have access to the puppet-community namespace, so you guys are on your own for releasing this. Godspeed!

@ffrank
Copy link
Contributor Author

ffrank commented Jun 22, 2015

Here's a basic metadata.json. What platforms do we support, exactly?

@nibalizer
Copy link
Member

#114 is what we need to be able to travis-deploy

@ffrank ffrank force-pushed the 0.5.x branch 3 times, most recently from ff8a444 to cce9127 Compare June 24, 2015 23:43
@ffrank
Copy link
Contributor Author

ffrank commented Jun 24, 2015

Any ideas on how to supply Travis with augeas?

@nibalizer
Copy link
Member

Well I tried that one thing....

@ffrank
Copy link
Contributor Author

ffrank commented Jul 3, 2015

@nibalizer use your words, dude.

@nibalizer
Copy link
Member

I tried https://github.com/puppet-community/puppet-network/pull/114/files setting sudo to true and adding some install agueas apt get commands. Doesn't seem to have worked.

@nibalizer
Copy link
Member

@DavidS can you help us get these tests passing?

@ffrank
Copy link
Contributor Author

ffrank commented Jul 3, 2015

Commented on #114. Looks good, I think with the before_install, getting augeas gems will work...(?)

Will try that here later.

@ffrank
Copy link
Contributor Author

ffrank commented Jul 7, 2015

Or @adrienthebo? You had those tests passing somewhere, right?

I'd like to run them at home, but I'm currently having fun with my pre-packaged Ruby 2.1 barfing severely upon the json_pure gem.

@DavidS
Copy link
Contributor

DavidS commented Jul 8, 2015

It seems to fail on requiring augeas >= 0.10 in the kmod module. Have you tried adding the ruby-augeas gem or stubbing $::augeasversion?

@igalic
Copy link
Contributor

igalic commented Aug 6, 2015

any news here?
@raphink can you help?

@ffrank
Copy link
Contributor Author

ffrank commented Aug 7, 2015

This should be the same fix that dom advised for another PR.

@igalic
Copy link
Contributor

igalic commented Aug 7, 2015

@ffrank wanna rebase this?

@igalic
Copy link
Contributor

igalic commented Aug 13, 2015

@ffrank wanna rebase this, so we can release? :D

@ffrank
Copy link
Contributor Author

ffrank commented Aug 13, 2015

Thanks for the reminder. Will look into it next chance.

@ffrank
Copy link
Contributor Author

ffrank commented Aug 13, 2015

Merge and release away.

igalic added a commit that referenced this pull request Aug 13, 2015
Release version 0.5.x in the puppet-community namespace
@igalic igalic merged commit caa4002 into voxpupuli:master Aug 13, 2015
@igalic
Copy link
Contributor

igalic commented Aug 13, 2015

@ffrank hm… that didn't create a tag…
should it have created a tag?

@nibalizer
Copy link
Member

No this doesn't create a tag. You have to create the tag and push it in.

@ffrank
Copy link
Contributor Author

ffrank commented Aug 17, 2015

TIL :/

@igalic
Copy link
Contributor

igalic commented Aug 20, 2015

current status: 🔥 💻 💥

igalic@levix ~/s/p/puppet-network (master ⚡↩=) [1]> rake module:release
WARN: Unresolved specs during Gem::Specification.reset:
      json_pure (>= 0)
WARN: Clearing out unresolved specs.
Please report a bug if this causes problems.
Cleaning for module build
rake aborted!
Don't know how to build task 'clean'

Tasks: TOP => module:release => module:clean
(See full trace by running task with --trace)
igalic@levix ~/s/p/puppet-network (master ⚡↩=) [1]> 

ping @carlossg

@carlossg
Copy link
Member

I guess you just need a clean task in the Rakefile

@daenney
Copy link
Member

daenney commented Aug 20, 2015

That should be provided by the blacksmith thingy if it depends on it.

@carlossg
Copy link
Member

actually what you need to include is

require 'puppetlabs_spec_helper/rake_tasks' # needed for some module packaging tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants