-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate adrien-network #105
Conversation
@ffrank I assume that you want a release pushed once this is done? |
Yes, this is supposed to be the final release in the original namespace. Perhaps the README needs more direct wording to that effect? |
Wait, I failed to touch the module file also. Go me :) |
We need to make sure that this pull request never gets published to the puppet-community namespace. That side, once the module metadata is updated to 0.4.2 I can merge and release. |
@ffrank we have a build failure, that needs to be cleaned up before we can release. |
puppetlabs increased the version on one of their modules to 99.99.99: https://forge.puppetlabs.com/puppetlabs/mcollective Maybe this should be applied here as well? I'm looking into the build error at the moment to see if I can fix it. |
Yes, but I'm not a fan. I vaguely remember some module where another post-last-minute change was desirable, but could not be released thanks to those shenanigans. |
Apparently #107 only fixes half the travis jobs. 😤 For Ruby 1.8.7, we'd need to pin the puppet version to |
I have tried to get tests running locally, but after a few hours of agony, I give up: https://gist.github.com/JimPanic/9654d85332be88228e1f bundle exec rake spec doesn't find ruby-augeas. But puppet apply does. I even built ruby-augeas myself, it just doesn't work. |
82d3b4f
to
4050150
Compare
4050150
to
fdbaa82
Compare
@ffrank <3 |
yey! 👍 |
\o/ Cheers to @JimPanic for repair work! |
Makes one last release in the
0.4.x
branch to link to the new forge presence in the community namespace.