Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate adrien-network #105

Merged
merged 1 commit into from
Jun 18, 2015

Conversation

ffrank
Copy link
Contributor

@ffrank ffrank commented Jun 16, 2015

Makes one last release in the 0.4.x branch to link to the new forge presence in the community namespace.

@adrienthebo
Copy link
Member

@ffrank I assume that you want a release pushed once this is done?

@ffrank
Copy link
Contributor Author

ffrank commented Jun 16, 2015

Yes, this is supposed to be the final release in the original namespace.

Perhaps the README needs more direct wording to that effect?

@ffrank
Copy link
Contributor Author

ffrank commented Jun 16, 2015

Wait, I failed to touch the module file also. Go me :)

@adrienthebo
Copy link
Member

We need to make sure that this pull request never gets published to the puppet-community namespace. That side, once the module metadata is updated to 0.4.2 I can merge and release.

@adrienthebo
Copy link
Member

@ffrank we have a build failure, that needs to be cleaned up before we can release.

@JimPanic
Copy link
Contributor

puppetlabs increased the version on one of their modules to 99.99.99: https://forge.puppetlabs.com/puppetlabs/mcollective

Maybe this should be applied here as well?

I'm looking into the build error at the moment to see if I can fix it.

@ffrank
Copy link
Contributor Author

ffrank commented Jun 17, 2015

Yes, but I'm not a fan. I vaguely remember some module where another post-last-minute change was desirable, but could not be released thanks to those shenanigans.

@JimPanic
Copy link
Contributor

Apparently #107 only fixes half the travis jobs. 😤

For Ruby 1.8.7, we'd need to pin the puppet version to ~> 3.7 in the 0.4.x branch - or ditch Ruby 1.8.7 support.

@JimPanic
Copy link
Contributor

I have tried to get tests running locally, but after a few hours of agony, I give up:

https://gist.github.com/JimPanic/9654d85332be88228e1f

bundle exec rake spec doesn't find ruby-augeas. But puppet apply does. I even built ruby-augeas myself, it just doesn't work.

@ffrank ffrank force-pushed the deprecate-adrien-network branch from 82d3b4f to 4050150 Compare June 18, 2015 10:25
@ffrank ffrank force-pushed the deprecate-adrien-network branch from 4050150 to fdbaa82 Compare June 18, 2015 10:26
adrienthebo added a commit that referenced this pull request Jun 18, 2015
@adrienthebo adrienthebo merged commit 129547c into voxpupuli:0.4.x Jun 18, 2015
@adrienthebo
Copy link
Member

@adrienthebo
Copy link
Member

@ffrank <3

@JimPanic
Copy link
Contributor

yey! 👍

@ffrank
Copy link
Contributor Author

ffrank commented Jun 18, 2015

\o/ Cheers to @JimPanic for repair work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants