Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant + Puppet #80

Closed
boesing opened this issue Aug 25, 2014 · 2 comments
Closed

Vagrant + Puppet #80

boesing opened this issue Aug 25, 2014 · 2 comments

Comments

@boesing
Copy link

boesing commented Aug 25, 2014

Hey there,

I cannot use your plugin in combination with vagrant.
After vagrant provision, the /etc/network/interfaces file gets totally overridden which ends up with a malformed interfaces file.
Vagrant adds some kind of wrapper around its configuration:

# VAGRANT-BEGIN
# VAGRANT-END

Well - after provisioning with puppet, the file doesnt have these comments and on the next vagrant up, vagrant creates a new section with same configuration as before. After this, the same interface is created twice and ifup wont let the interface start without an error.

Could you fix your plugin so that the comments some1 has written into that interfaces file will stay?

Thanks in advance,
Max

@adrienthebo
Copy link
Member

Honestly? No, not really. Making this work at all would mean rewriting the parser from scratch. Granted that needs to be done for other reasons, but it's a lot of work. In addition the semantics of the interfaces file makes it very challenging to associate comments with specific statements in the file, and respecting the comment markers like what vagrant does means that the parser would have to be custom built to respect that.

@adrienthebo
Copy link
Member

Now if someone submitted a pull request that implemented a stateful parser that could handle it and the implementation was of sufficient quality, I would totally consider merging it. However I've been fighting off RSI for months now and I'm pretty sure that rewriting this parser right here and now would ensure that I wouldn't do any coding for several months after. Yay tendons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants