Spec failures on redhat

[adrienthebo]

Failures:
  1) Puppet::Type::Network_config::ProviderInterfaces when formatting writing iface blocks should add all options following the iface block
     Failure/Error: content.split('\n').find {|line| line.match(/iface eth0/)}.should be_include(block)
       expected include?("iface eth0 inet static\naddress 169.254.0.1\nnetmask 255.255.0.0") to return true, got false
     # ./spec/unit/provider/network_config/interfaces_spec.rb:174
Finished in 0.5945 seconds
143 examples, 1 failure, 9 pending
Failed examples:
rspec ./spec/unit/provider/network_config/interfaces_spec.rb:168 # Puppet::Type::Network_config::ProviderInterfaces when formatting writing iface blocks should add all options following the iface block

This occurs when running on redhat version 6.3.

[ericsakowski]

FWIW I noticed this is failing on travis as well. Strange part: if I run the rspec -f h, the test passes. If I run it w/ -f d, or don't specify a format the test fails. If I add in my specfile for redhat routes, the above failing test passes.

[adrienthebo]

@ericsakowski I think I found the issue, it was a heisenbug with hash ordering, which should be fixed. Could you verify that this is solved?

[ericsakowski]

I reproduced the failed test, pulled, and verified that it passes now:

Checked that specific test is run:
.
.
writing iface blocks
should produce an iface block for each interface
should add all options following the iface block
.
.
Finished in 0.39171 seconds
152 examples, 0 failures, 9 pending
[root@puppetski puppet-network]# git log -1
commit 139f274
Author: Adrien Thebo [email protected]
Date: Sun Mar 3 19:05:17 2013 -0800

Remove comments for debian auto and hotplug stanzas

[root@puppetski puppet-network]#

Looks good!

[adrienthebo]

This should be fixed by 2313bcb . Thanks again for reporting this!