Extra json on mongo output causing provider 'mongodb': 783: unexpected token at '{

[xepa]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 7.26.0
• Ruby: 2.7.8p225
• Distribution: ubuntu
• Module version: master

How to reproduce (e.g Puppet code you use)

we are running this on an established mongodb instance,

What are you seeing

running any /usr/bin/mongo command cli returns an extra json line, this is related to SERVER-78540 it would seem and was fixed in 4.x and 6.x but not yet in 5.x (running 5.0.21 atm)

output of command will result in something like

{"t":{"$date":"2023-09-12T06:33:42.971Z"},"s":"I",  "c":"NETWORK",  "id":5490002, "ctx":"thread4","msg":"Started a new thread for the timer service"}
{
  "databases" : [
    {
      "name" : "admin",
      "sizeOnDisk" : NumberLong(184320),
      "empty" : false
    },
    {
      "name" : "config",
      "sizeOnDisk" : NumberLong(110592),
      "empty" : false
    },
    {
      "name" : "local",
      "sizeOnDisk" : NumberLong(81920),
      "empty" : false
    }
  ],
  "totalSize" : NumberLong(1261928448),
  "totalSizeMb" : NumberLong(1203),
  "ok" : 1
}

Error will be something like

Error: Could not prefetch mongodb_database provider 'mongodb': 783: unexpected token at '{

What behaviour did you expect instead

In my opinion this extra line should be removed in lib/puppet/util/mongodb_output.rb

[witjoh]

/usr/bin/mongo is deprecated in favor of /usr/bin/mongosh .. And it is removed in version 6. Working on #677 which only supports mongosh, and version 4.4+ of mongodb.
But i need to finalize this PR. (like cleaning commits, get extra acceptance tests ...) Just need more hours in a day :)

[xepa]

This sounds like a better approach, .. I just whipped up this small fix in the mean time as it was causing the puppet run to fail. If there is anything that I could do please let me know.

[witjoh]

I'm only testing my branch on Redhat flavours .. So in time someone testing it in Ubunto and aother flavours could help. And since version 7.0 is out .. thats also new ground to cover :)