Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Cron parameter on letsencrypt::certonly will not cleanup resources. #284

Open
bkuebler opened this issue Apr 23, 2022 · 2 comments
Open

Comments

@bkuebler
Copy link
Contributor

bkuebler commented Apr 23, 2022

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: any
  • Ruby: any
  • Distribution: any
  • Module version: any

How to reproduce (e.g Puppet code you use)

Use letsencrypt::certonly resource with parameter manage_cron => true, then set this parameter to false

What are you seeing

Renewal script and cronjob for this resource will be applied. After set to manage_cron => false nothing happened.

What behaviour did you expect instead

After disable the manage_cron parameter i expect, that the file and cronjob will be removed.

Output log

Any additional information you'd like to impart

If i use a boolean parameter in a resource i would expect, that if i switch it from false to true and then again to false or vice-versa it should always revert the changes which has be done on the system.

@kenyon
Copy link
Member

kenyon commented Apr 23, 2022

Not sure about this. Do we have any other modules that work like this?

@ekohl
Copy link
Member

ekohl commented Apr 23, 2022

After disable the manage_cron parameter i expect, that the file and cronjob will be removed.

Typically the manage_* parameters ensure it's either managed or not. If it's not managed, it's fair game because it isn't in the catalog. Often there's also a parameter that ensures it's in whatever state (like present or absent).

IMHO it's fair that you want something to clean it up, but the manage parameter is not the one for that IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants