Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The kafka::broker::topic defined type should rather be kafka::topic #188

Closed
LionelCons opened this issue Jul 25, 2017 · 0 comments · Fixed by #189
Closed

The kafka::broker::topic defined type should rather be kafka::topic #188

LionelCons opened this issue Jul 25, 2017 · 0 comments · Fixed by #189

Comments

@LionelCons
Copy link
Contributor

The module only has one defined type, used to manage topics: kafka::broker::topic.

However, this code has nothing in common with kafka::broker. It is generic and could equally well be used along with brokers, producers or consumers.

So this defined type should rather be named kafka::topic.

Note also that the manifests/broker/topic.pp file has incorrect documentation as it contains:

# This private class is meant to be called from `kafka::broker`.

It is not a (private) class and it is not called from kafka::broker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant