Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate templates #67

Closed
alexjfisher opened this issue Feb 14, 2020 · 2 comments · Fixed by #79
Closed

Consolidate templates #67

alexjfisher opened this issue Feb 14, 2020 · 2 comments · Fixed by #79

Comments

@alexjfisher
Copy link
Member

I've noticed that the chrony.conf.redhat.erb and chrony.conf.debian.erb are the exact same file and chrony.conf.archlinux.erb is missing several options.

I think it would make sense to have just a single template (epp whilst we're at it).

@aboe76
Copy link
Contributor

aboe76 commented Feb 14, 2020

@alexjfisher that would be a better solution, at first the idea was to have them separated and nicely formatted the way the distro's provided the default files.

But considering the multiple extra params now I think it would be better to have the module provide the config file with all the managed parameters.

@alexjfisher alexjfisher added this to the 1.0.0 milestone Feb 22, 2020
@chrekh
Copy link
Contributor

chrekh commented Jul 9, 2020

I have made a attempt at doing this. #79

@ekohl ekohl linked a pull request Jul 9, 2020 that will close this issue
@ekohl ekohl closed this as completed in #79 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants