-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Ruby 3.1 #1906
base: master
Are you sure you want to change the base?
Require Ruby 3.1 #1906
Conversation
af4d4c4
to
d627817
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1906 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 79 79
Lines 4395 4395
=======================================
Hits 3264 3264
Misses 1131 1131 ☔ View full report in Codecov by Sentry. |
Ruby 3.0 and older are dead upstream. Requiring 3.1 or newer allows us to safely use latest gem dependencies. Beaker isn't tied to the Puppet AIO Ruby versions, so we don't need to stay on Ruby 2.6 or 2.7.
Tested in voxpupuli/puppet-example#78 |
So when any gem in a Gemfile requires a Ruby version that's newer than your local Ruby, bundler will stop. it doesn't matter if the Gem group is disabled or not. A simple workaround I came up with (https://github.com/voxpupuli/puppet-example/pull/78/files):
We could easily add this to our modulesync_config. If that's fine for you, we can continue dropping old Ruby/minitar here in beaker. |
Ruby 3.0 and older are dead upstream. Requiring 3.1 or newer allows us to safely use latest gem dependencies. Beaker isn't tied to the Puppet AIO Ruby versions, so we don't need to stay on Ruby 2.6 or 2.7.