Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links that are relative to root are treated as broken #5

Open
johlju opened this issue Aug 7, 2018 · 3 comments
Open

Links that are relative to root are treated as broken #5

johlju opened this issue Aug 7, 2018 · 3 comments

Comments

@johlju
Copy link

johlju commented Aug 7, 2018

Tried MarkdownLinkCheck, and it finds broken links in my tests, but there are one issue, do you know if it can be solved (easily)? The issue is that it seems to think a correct link that points to a folder is broken. For example it fails on all the links in the README.md here.

https://github.com/PowerShell/SqlServerDsc/tree/dev/Examples

Path       : C:\Source\SqlServerDsc\Examples\README.md
Text       : SqlAG
Url        : /Examples/Resources/SqlAG
IsBroken   : True
IsAbsolute : False
Line       : 10
Column     : 3
@vors
Copy link
Owner

vors commented Aug 10, 2018

I see. You are using the /foo/bar to indicate that link is relative to the root of the repo.
Could I ask is there any reason you prefer to use /Examples/Resources/SqlAG instead of Resources/SqlAG ?

@johlju
Copy link
Author

johlju commented Aug 10, 2018

Ah, thank you! There was no reason other than it worked, since the link worked I did not think of that it wasn't a relative path. and that a relative path would work better. 🙂 Changed the links, and they still work, and the test are passing!
Thanks for helping with this, appreciate it a lot! 😃 🙇

@johlju johlju closed this as completed Aug 10, 2018
@vors vors changed the title Lists links to folders as broken Links that are relative to root are treated as broken Aug 11, 2018
@vors
Copy link
Owner

vors commented Aug 11, 2018

Great! Let's keep it open, since it's a valid syntax, but just not a very common one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants