Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating is not accessible via tab #51

Open
Theartbug opened this issue Jun 18, 2018 · 1 comment
Open

Rating is not accessible via tab #51

Theartbug opened this issue Jun 18, 2018 · 1 comment

Comments

@Theartbug
Copy link

Cannot use keyboard tab to access each individual rating input.

Current behavior: pressing tab skips over the entire component.

Desired behavior: tab would jump into the first rating and tab across them, selecting them when enter is pressed.

@nickLeidman
Copy link

nickLeidman commented Jul 19, 2019

Looked into code, making it "tababble" isn't that hard. Though several other problems emerge. Apparently value change is bound to click and I can not see painless way to solve this issue without rewriting most of value handling mechanism.

// do not update internal state based on input value if prop passed
if (value != null) { return; }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants