Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TooMuchDataException in DATA command returns 421 code? #89

Open
derelbenkoenig opened this issue Apr 18, 2018 · 2 comments
Open

TooMuchDataException in DATA command returns 421 code? #89

derelbenkoenig opened this issue Apr 18, 2018 · 2 comments

Comments

@derelbenkoenig
Copy link

It looks like there is no catch block for the TooMuchDataException specifically, so it will be caught in the general IOException catch in Session.java, which returns "421 4.4.0 Problem attempting to execute commands. Please try again later."

I believe this exception should translate either to 552 Requested mail action aborted: exceeded storage allocation or 452 Requested action not taken: insufficient system storage

Either that, or the Exception should simply be removed from the method signature. It is redundant as the method declares that it throws IOException anyway, and the implementation will need to throw a RejectException anyway if they want to have control over what error code is returned

@REME-AlarmTILT
Copy link

Give a look here : davidmoten@5c23887.
Maybe you should think to switch to the new fork by @davidmoten

@derelbenkoenig
Copy link
Author

That's an interesting idea but I don't think it addresses my particular concern; it looks like in that fork, the TooMuchDataException is still treated as an IOException which returns with the SMTP error code of 421, while I was suggesting 452 or 552 for too much data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants