Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ValueScript source code more rusty #4

Open
voltrevo opened this issue Mar 8, 2023 · 0 comments
Open

Make the ValueScript source code more rusty #4

voltrevo opened this issue Mar 8, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@voltrevo
Copy link
Owner

voltrevo commented Mar 8, 2023

I've been learning rust as I've been building ValueScript. I'm getting better, but I'm sure the code would still benefit by being rustier in many places.

At minimum, cargo clippy is generating 470 warnings as I write this (after --fix).

I'm not necessarily sold on doing everything clippy says, but it's a decent guide.

If you want to change something a bit more complex than what clippy is able to comment on, you might want to check with me beforehand. In general, this is supposed to be a good-first-issue so the depth of the change should be limited.

@voltrevo voltrevo added the good first issue Good for newcomers label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant