Revert RSASSA-PSS parameters #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts aabcdbb. I believe the parameters used in the HTTP signatures compliance test suite are actually incorrect, and the draft itself does not specify any special values.
There is no reason to believe the authors of the spec intended to use a non-default hash function, especially since this would go against best practices mentioned in RFC8017 (referenced from the spec) and would hurt interoperability, as not all libraries allow the user to modify the PSS defaults.
Hopefully any ambiguity will be cleared up as the new draft-ietf-httpbis-message-signatures (see #1) matures.