Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve to a default version for each toolchain if already exists #64

Closed
monshi opened this issue Apr 30, 2018 · 1 comment · Fixed by #372
Closed

resolve to a default version for each toolchain if already exists #64

monshi opened this issue Apr 30, 2018 · 1 comment · Fixed by #372

Comments

@monshi
Copy link
Contributor

monshi commented Apr 30, 2018

I installed notion on my mac 🎉🚀 and got so excited 💃🕺so that the first thing I did after that was to run node -v in the same directory and I got this error: error: An unknown error has occurred.
I was assuming that if there is no package.json or notion config block then notion will either fall back to a default version of node or will respect my previously installed version of node. By that I mean, when the notion is installed on a machine it can detect and install the global version of my installed toolchain (node, yarn ...) and set them as default versions.

If the expected behavior is not as I assumed, then maybe another option would be showing some instructions/helpful errors instead of error: An unknown error has occurred. I'll be happy to help fixing it as well :)

@charlespierce
Copy link
Contributor

The error message part of this issue has been resolved with the error rework. The pass-through to existing tools is currently in review in #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants