Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit codes #49

Closed
dherman opened this issue Mar 6, 2018 · 3 comments
Closed

exit codes #49

dherman opened this issue Mar 6, 2018 · 3 comments
Labels
code quality

Comments

@dherman
Copy link
Collaborator

dherman commented Mar 6, 2018 •
edited
Loading

There should be a single module that contains a full encyclopedia of exit codes, and all the error types throughout notion-core and the main crate should pull their exit codes from that module.

Thanks to @benblank we have an exit codes RFC!
@mikrostew
Copy link
Contributor

This looks like what is proposed in volta-cli/rfcs#20 - we should be able to implement this after that RFC is merged.

@dherman dherman changed the title error exit code encyclopedia exit codes Aug 21, 2018
@dherman
Copy link
Collaborator Author

dherman commented Aug 21, 2018

The implementation PR is #114.

@dherman dherman mentioned this issue Aug 21, 2018
Merged
@benblank
Copy link
Contributor

This should have been closed when #114 was merged; oops!

@andrewplummer andrewplummer mentioned this issue Jan 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikrostew @benblank @dherman