Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New version of npm available" shown after notion install #369

Closed
mikrostew opened this issue Apr 19, 2019 · 3 comments · Fixed by #394
Closed

"New version of npm available" shown after notion install #369

mikrostew opened this issue Apr 19, 2019 · 3 comments · Fixed by #394

Comments

@mikrostew
Copy link
Contributor

Sometimes, but not every time, Npm shows a "New version of npm available" printout after the install completes:

$ notion install cowsay 1.3.0
  Fetching cowsay-v1.3.0  [========================================] 100%
npm notice created a lockfile as package-lock.json. You should commit this file.
added 9 packages from 2 contributors and audited 1535 packages in 30.198s
found 0 vulnerabilities



   ╭───────────────────────────────────────────────────────────────╮
   │                                                               │
   │       New minor version of npm available! 6.7.0 → 6.9.0       │
   │   Changelog: https://github.com/npm/cli/releases/tag/v6.9.0   │
   │               Run npm install -g npm to update!               │
   │                                                               │
   ╰───────────────────────────────────────────────────────────────╯

This is annoying, and won't work because we will block the global install.

There is probably a way to suppress this (env variable, or a setting somewhere).

@charlespierce
Copy link
Contributor

From this issue npm/npm#17453, it looks like we may be able to set NO_UPDATE_NOTIFIER when calling npm to suppress that message.

@kimroen
Copy link

kimroen commented Jul 15, 2019

Just wanted to note that I'm getting this also when running various npm commands, like npm run lint:

➜ npm run lint:js

> [email protected] lint:js ~/path/to/project
> eslint .



   ╭────────────────────────────────────────────────────────────────╮
   │                                                                │
   │       New minor version of npm available! 6.4.1 → 6.10.1       │
   │   Changelog: https://github.com/npm/cli/releases/tag/v6.10.1   │
   │               Run npm install -g npm to update!                │
   │                                                                │
   ╰────────────────────────────────────────────────────────────────╯

Running npm install -g npm as instructed then shows this error:

➜ npm install -g npm
Volta error: Global package installs are not supported.

Use `volta install npm` to add a package to your toolchain (see `volta help install` for more info).

Which then leads to running this command, and getting this error:

➜ volta install npm
error: Installing npm is not supported yet.

@charlespierce
Copy link
Contributor

Hi @kimroen, thanks for raising that! We're tracking adding support for installing a specific version of npm in #292.

In the interim, this is a bad UX and we should update our error messaging to explicitly call-out (in npm install -g npm) that it's not supported yet instead of telling you to do something that then itself errors out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants