Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notion deactivate should work in invalid configuration scenarios #236

Closed
rwjblue opened this issue Jan 10, 2019 · 0 comments
Closed

notion deactivate should work in invalid configuration scenarios #236

rwjblue opened this issue Jan 10, 2019 · 0 comments

Comments

@rwjblue
Copy link
Contributor

rwjblue commented Jan 10, 2019

Running notion deactivate should only deactivate for the current shell. It should continue to work even in the following situations:

  • invalid toolchain section in package.json
  • invalid user configuration
  • missing/incorrect images
@rwjblue rwjblue changed the title notion deactivate should work in malformed toolchain scenarios notion deactivate should work in invalid configuration scenarios Jan 10, 2019
@charlespierce charlespierce mentioned this issue Jan 10, 2019
Merged
@andrewplummer andrewplummer mentioned this issue Jan 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwjblue