Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shim executable #176

Closed
10 tasks
dherman opened this issue Oct 19, 2018 · 1 comment
Closed
10 tasks

Create shim executable #176

dherman opened this issue Oct 19, 2018 · 1 comment
Labels

Comments

@dherman
Copy link
Collaborator

dherman commented Oct 19, 2018

Eliminate launchbin and launchscript and replace with a single shim executable:

  • Remove the launch{bin, script} binaries
  • Create a shim binary
  • Installer should install it to ~/.notion/exe/shim
  • use https://crates.io/crates/process_path to figure out the executable name
  • first try to use the project toolchain (this logic already exists)
  • next try to read ~/.notion/tools/user/bins/$name/package.toml
  • get the tool path from the toml data
  • launch ~/.notion/tools/user/installed/$package/$toolpath (use cmd /c if this is Windows and it's a legacy batch/cmd script)
  • finally default to delegating to next thing in PATH

Depends on:

@charlespierce
Copy link
Contributor

I think the architecture of the code in Volta has moved beyond the specific details of this issue, and we do now have a volta-shim executable that handles the shim behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants