Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hwdef as approver #3643

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Jul 31, 2024

ref: volcano-sh/community#58

I have been an approver of the controller and webhook modules for some time.“Now I am applying to become an approver of the entire repo . I hope to bring more contributions to the community. Thank you.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2024
@william-wang
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@Monokaix
Copy link
Member

Monokaix commented Aug 2, 2024

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
@volcano-sh-bot volcano-sh-bot merged commit 80d9516 into volcano-sh:master Aug 2, 2024
14 checks passed
@hwdef hwdef deleted the add-approver branch August 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants