Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade kube-state-metrics image versio to v2.0.0-beta from v1.9.7 #3566

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

lengrongfu
Copy link
Contributor

Fixes: #3564

To avoid too big a version change, only a minor version was upgraded.

v1.9.8 version having multi arch image. https://explore.ggcr.dev/?image=registry.k8s.io%2Fkube-state-metrics%2Fkube-state-metrics:v1.9.8

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2024
@lengrongfu
Copy link
Contributor Author

/assign @wpeng102

@Monokaix
Copy link
Member

Monokaix commented Jul 9, 2024

Welcome and thanks for contribution! And have you tested it with volcano-monitoring-latest.yaml deployed?

@william-wang
Copy link
Member

@lengrongfu Thanks for your contrinbution. Have triggered the ci :)

@lengrongfu
Copy link
Contributor Author

Welcome and thanks for contribution! And have you tested it with volcano-monitoring-latest.yaml deployed?

pod can success running.

image
image

@lengrongfu lengrongfu force-pushed the master branch 2 times, most recently from 472bf99 to b92f509 Compare July 10, 2024 08:49
@Monokaix
Copy link
Member

Thanks for your contribution! volcano forked kube-state-metrics repo and add some custuom metrics, the repo is here: https://github.com/volcano-sh/kube-state-metrics.git, and the image released from this repo has been upload to dockerhub, image name is volcanosh/kube-state-metrics:v2.0.0-beta, you can try that and update the image name to it by modifying this pr.

@lengrongfu
Copy link
Contributor Author

Thanks for your contribution! volcano forked kube-state-metrics repo and add some custuom metrics, the repo is here: https://github.com/volcano-sh/kube-state-metrics.git, and the image released from this repo has been upload to dockerhub, image name is volcanosh/kube-state-metrics:v2.0.0-beta, you can try that and update the image name to it by modifying this pr.

Thanks, update to volcanosh/kube-state-metrics:v2.0.0-beta.

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
@Monokaix
Copy link
Member

Hi, you can use git commit --ame --no-edit -s and force push again to re-trigger ci.

@william-wang
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2024
@Monokaix
Copy link
Member

/retitle upgrade kube-state-metrics image versio to v2.0.0-beta from v1.9.7

@Monokaix
Copy link
Member

Hi, please also change the title and description.

@lengrongfu lengrongfu changed the title upgrade kube-state-metrics image versio to 1.9.8. from v1.9.7 upgrade kube-state-metrics image versio to v2.0.0-beta from v1.9.7 Jul 31, 2024
@Monokaix
Copy link
Member

Monokaix commented Aug 1, 2024

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@volcano-sh-bot volcano-sh-bot merged commit 6e44698 into volcano-sh:master Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade kube-state-metrics version to v1.9.8/v2.12.0 from v1.9.7
5 participants