Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the publishNotReadyAddresses param for the svc plugin #533

Closed
zrss opened this issue Nov 18, 2019 · 1 comment · Fixed by #535
Closed

add the publishNotReadyAddresses param for the svc plugin #533

zrss opened this issue Nov 18, 2019 · 1 comment · Fixed by #535
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@zrss
Copy link
Contributor

zrss commented Nov 18, 2019 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

follow up by #526

ep is not ready during the Init status, ref the k8s doc

https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/

publishNotReadyAddresses, when set to true, indicates that DNS implementations must publish the notReadyAddresses of subsets for the Endpoints associated with the Service. The default value is false. The primary use case for setting this field is to use a StatefulSet's Headless Service to propagate SRV records for its Pods without respect to their readiness for purpose of peer discovery.

there should have a publishNotReadyAddresses param for svc plugin, as InitContainer may use the hosts info for swithing nics (multiple network plane, rather than the main network plain) info
@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2019
@k82cn k82cn added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 18, 2019
@zrss zrss mentioned this issue Nov 18, 2019
Merged
@d4l3k d4l3k mentioned this issue Mar 2, 2022
Closed
@streamnsight
Copy link

This issue was closed as resolved in the PR, but the PR was never merged.
the --publish-not-ready-addresses doesn't seem to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the --publish-not-ready-addresses param for the svc plugin zrss/volcano
4 participants
@zrss @streamnsight @k82cn @volcano-sh-bot