Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] NodeVolumeLimits directly return in predicate, result in VolumeZone and PodTopologySpread predicate not works #3726

Closed
JesseStutler opened this issue Sep 14, 2024 · 0 comments · Fixed by #3727
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@JesseStutler
Copy link
Member

JesseStutler commented Sep 14, 2024

Description

When I want to test pod topology spread constraints, I found that only prefilter worked fine, but filter in PodToplogySpread did not work. By adding some logs, finally I found that it was because in predicateFn, nodeVolumeLimits is enabled by default, and it directly returns, didn't check whether the status is api.Success. Introduced by #3553
image

Steps to reproduce the issue

  1. Directly install volcano, not change any configuration file
  2. Deploy a topology spread constraints deployment
  3. Pod won't be scheduled evenly

Describe the results you received and expected

Received

By adding some logs, I found that there was no VolumeZone and PodTopologySpread predicting, but entered NodeVolumeLimits.
image

Expected

VolumeZone and PodTopologySpread predicting should work fine. But if NodeVolumeLimits is enabled, VolumeZone and PodTopologySpread can't work.

What version of Volcano are you using?

1.10

Any other relevant information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant