Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler plugin arguments failed to readin "1" as float64. #2539

Closed
jiangkaihua opened this issue Oct 17, 2022 · 0 comments · Fixed by #2540
Closed

Scheduler plugin arguments failed to readin "1" as float64. #2539

jiangkaihua opened this issue Oct 17, 2022 · 0 comments · Fixed by #2540
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jiangkaihua
Copy link
Contributor

What happened:

When I set overcommit plugin argument: overcommit-factor to '2' in configmap, like:

configmap

And then volcano scheduler threw out a warning, and my configuration did not take effect.

scheduler-log

I think the question was probably caused by type assertions in plugin argument interface:

value, ok := argv.(float64)

Current method could not convert int to float64.

What you expected to happen:

Interger value can be readin as well.

How to reproduce it (as minimally and precisely as possible):

As below, and would also happen on other plugins.

Anything else we need to know?:

Environment:

  • Volcano Version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@jiangkaihua jiangkaihua added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant