fix jobflow CRD metadata.annotations: Too long error

Signed-off-by: wangyang <[email protected]> Signed-off-by: guoqinwill <[email protected]>
volcano-sh · Mar 18, 2024 · f7db59b · f7db59b
1 parent f0d99bf
commit f7db59b
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 16,149 deletions.
diff --git a/Makefile b/Makefile
@@ -114,6 +114,8 @@ manifests: controller-gen
 	$(CONTROLLER_GEN) "crd:maxDescLen=0,crdVersions=v1beta1" paths="./vendor/volcano.sh/apis/pkg/apis/batch/v1alpha1" output:crd:artifacts:config=config/crd/volcano/v1beta1
 	# jobflow crd base
 	$(CONTROLLER_GEN) $(CRD_OPTIONS) paths="./vendor/volcano.sh/apis/pkg/apis/flow/v1alpha1" output:crd:artifacts:config=config/crd/jobflow/bases
+  # generate volcano jobflow crd yaml without description to avoid yaml size limit when using `kubectl apply`
+	$(CONTROLLER_GEN) $(CRD_OPTIONS_EXCLUDE_DESCRIPTION) paths="./vendor/volcano.sh/apis/pkg/apis/flow/v1alpha1" output:crd:artifacts:config=config/crd/jobflow/bases
 
 unit-test:
 	go clean -testcache

diff --git a/config/crd/jobflow/bases/flow.volcano.sh_jobflows.yaml b/config/crd/jobflow/bases/flow.volcano.sh_jobflows.yaml
@@ -28,28 +28,17 @@ spec:
     name: v1alpha1
     schema:
       openAPIV3Schema:
-        description: JobFlow is the Schema for the jobflows API
         properties:
           apiVersion:
-            description: 'APIVersion defines the versioned schema of this representation
-              of an object. Servers should convert recognized schemas to the latest
-              internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
             type: string
           kind:
-            description: 'Kind is a string value representing the REST resource this
-              object represents. Servers may infer this from the endpoint the client
-              submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
             type: string
           metadata:
             type: object
           spec:
-            description: JobFlowSpec defines the desired state of JobFlow
             properties:
               flows:
-                description: Foo is an example field of JobFlow. Edit jobflow_types.go
-                  to remove/update
                 items:
-                  description: Flow defines the dependent of jobs
                   properties:
                     dependsOn:
                       properties:
@@ -59,16 +48,10 @@ spec:
                               items:
                                 properties:
                                   httpHeader:
-                                    description: HTTPHeader describes a custom header
-                                      to be used in HTTP probes
                                     properties:
                                       name:
-                                        description: The header field name. This will
-                                          be canonicalized upon output, so case-variant
-                                          names will be understood as the same header.
                                         type: string
                                       value:
-                                        description: The header field value
                                         type: string
                                     required:
                                     - name
@@ -118,7 +101,6 @@ spec:
                 type: string
             type: object
           status:
-            description: JobFlowStatus defines the observed state of JobFlow
             properties:
               completedJobs:
                 items:
@@ -131,20 +113,16 @@ spec:
                       format: date-time
                       type: string
                     phase:
-                      description: JobPhase defines the phase of the job.
                       type: string
                     runningDuration:
                       type: string
                     taskStatusCount:
                       additionalProperties:
-                        description: TaskState contains details for the current state
-                          of the task.
                         properties:
                           phase:
                             additionalProperties:
                               format: int32
                               type: integer
-                            description: The phase of Task.
                             type: object
                         type: object
                       type: object
@@ -175,15 +153,13 @@ spec:
                             format: date-time
                             type: string
                           state:
-                            description: JobPhase defines the phase of the job.
                             type: string
                         type: object
                       type: array
                     startTimestamp:
                       format: date-time
                       type: string
                     state:
-                      description: JobPhase defines the phase of the job.
                       type: string
                   type: object
                 type: array