-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v1.6.0 broke Laravel's builds #74
Comments
I am currently in the hospital (my little girl had her heart operation last week, everything went well 🙏) and I will take a look this evening. "It's more a fix for the current behaviour for Russia ascii mappings, but I can re-tag with a major version anyway. Should I remove the old tag? 🤔" - https://twitter.com/suckup_de/status/1485641365233049605?t=ncRafqzpgbWbFXIiL2HFUw |
Ow man, don't worry about it at all. We already fixed it on our end by limiting the constraint to Hope your girl recovers soon! ❤️ |
@driesvints I reverted the "ASCII"-mappings and tagged 1.6.1 and 2.0.0 1.6.1...2.0.0 |
@voku thanks a lot! 👏 |
What is this feature about (expected vs actual behaviour)?
Seems like release v1.6.0 broke Laravel's build and subsequently all PR's that are sent in since are failing as well: https://github.com/laravel/framework/runs/4920401730?check_suite_focus=true#step:8:138
It seems most likely that this commit is the culprit: acaf868
Changing the behaviour here seems like a breaking change to me and should probably be done in a major release?
How can I reproduce it?
Expected output:
pizdyuk.txt
(pre 1.6.0)Given output:
pizdiuk.txt
(as of 1.6.0)Does it take minutes, hours or days to fix?
Think this is an easy fix by just rolling back the commit and tagging a new patch release.
The text was updated successfully, but these errors were encountered: