Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German transcription with plural is wrong #38

Open
osworx opened this issue Dec 14, 2019 · 3 comments
Open

German transcription with plural is wrong #38

osworx opened this issue Dec 14, 2019 · 3 comments

Comments

@osworx
Copy link

osworx commented Dec 14, 2019

According to your description:

For example, German will map 'ä' to 'ae', while other languages will simply return e.g. 'a'.

this is wrong.
Example:
1 Apfel ( 1 Aple ) > nothing to convert
2 Äpfel (2 Apples) > you will convert Ä to A which is wrong because with an A only the 2 Apples become 1 Apple.
Maybe this sample is a bit hard to understand, but 1 Apfel = 1 Apple , 2 (or more) Äpfel are more Apples.
The only difference is the first letter, either an A or an Ä

Same will be with your sample Düsseldorf, converting it to en for example will translate Düsseldorf to Dusseldorf where it should be in all other languages than German Duesseldorf!
Dusseldorf may also exist as a town somewhere in Europe, if not Dussel means something very special in German (some stupid).

Translating German into other languages, especially for SEO-URLs is not that easy as it looks!
Please recheck and rework your framework, if it will handle such cases also correct, it could be useful.

@aimeos
Copy link

aimeos commented May 7, 2020

If you don't pass the right language, the replacements will be that for English. Use \voku\helper\ASCII::to_ascii( '2 Äpfel', 'de' ) to get 2 Aepfel.

BTW: The package has the best implementation we've seen up to now for transliteration! Great work :-)

@osworx
Copy link
Author

osworx commented May 8, 2020

If you don't pass the right language, the replacements will be that for English. Use \voku\helper\ASCII::to_ascii( '2 Äpfel', 'de' ) to get 2 Aepfel.

BTW: The package has the best implementation we've seen up to now for transliteration! Great work :-)

Aepfel is NOT Äpfel.
Can't understand why this is so hard to understand!

And what do you mean by "If you don't pass the right language .."
What shall I pass?

@voku
Copy link
Owner

voku commented Jul 6, 2020

If you don't pass the right language, the replacements will be that for English. Use \voku\helper\ASCII::to_ascii( '2 Äpfel', 'de' ) to get 2 Aepfel.
BTW: The package has the best implementation we've seen up to now for transliteration! Great work :-)

Aepfel is NOT Äpfel.
Can't understand why this is so hard to understand!

And what do you mean by "If you don't pass the right language .."
What shall I pass?

I am pretty sure that Ae is correct here, if you pass 'de' as language: https://de.wikipedia.org/wiki/Umlaut#Darstellung_von_Umlauten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants