Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Ukrainian to ASCII correct? #14

Open
voku opened this issue Sep 14, 2019 · 2 comments
Open

Is Ukrainian to ASCII correct? #14

voku opened this issue Sep 14, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@voku
Copy link
Owner

voku commented Sep 14, 2019

Example: Is this correct?

"діти" -> "diti"


Can a native speaker, please check the character-replacement, thanks.

https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L538

@voku voku added the good first issue Good for newcomers label Oct 15, 2019
@Andr1yk0
Copy link
Contributor

Hello, the correct transliteration for "діти" is "dity". Please check my PR with updates according to the official Ukrainian transliteration docs https://zakon.rada.gov.ua/laws/show/55-2010-%D0%BF?lang=en#Text

#59

@Andr1yk0
Copy link
Contributor

Also, I have a question.

In Ukrainian for some letters ('ю', 'я', 'Ї', etc) transliteration is different if it is the first letter in a word.
For example:
'яма' -> 'yama'
'пісня' -> 'pisnia'
The letter 'я' may be 'ya' or 'ia' depending on the letter position.

Do you think it's possible to implement this feature? May it be useful for other languages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants