Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated voku in php8.4alpha1 #101

Open
zxstudio-llc opened this issue Aug 15, 2024 · 9 comments
Open

Deprecated voku in php8.4alpha1 #101

zxstudio-llc opened this issue Aug 15, 2024 · 9 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@zxstudio-llc
Copy link

Deprecated: voku\helper\ASCII::to_ascii(): Implicitly marking parameter $replace_single_chars_only as nullable is deprecated, the explicit nullable type must be used instead in /Users/zx-studio/Herd/zx-studioweb/vendor/voku/portable-ascii/src/voku/helper/ASCII.php on line 795

@crynobone
Copy link

Hi @voku , PR #102 should solve the deprecation. Any chance we can merge that and get a tag soon?

@Diddyy
Copy link

Diddyy commented Oct 27, 2024

@voku Hey! Whats stopping this from being merged? Is there anything anyone can do to help progress it? :)

@zxstudio-llc
Copy link
Author

Yesterday I tried version 8.4 again but the error still appears so I continue working with version 8.3

@crynobone
Copy link

@voku PHP 8.4.0 is planned for November 21st, 2024 (in 10 days), can we get a this solve ASAP?

@MGeurts
Copy link

MGeurts commented Nov 20, 2024

PHP 8.4.0 and even 8.4.1 are already published at https://windows.php.net/downloads/releases/.

Could this please be resolved?
The warning is showing up in all Laravel 11 applications on PHP 8.4.

Thanks.

@duncanmcclean

This comment has been minimized.

@crynobone
Copy link

crynobone commented Nov 21, 2024

@duncanmcclean Unfortunately, after some tests, it isn't working 100%, and we still need to wait for a fix for this project.

@duncanmcclean
Copy link

duncanmcclean commented Nov 21, 2024

Looks like this might have been addressed by #105 🎉

@phildawson-gravity
Copy link

phildawson-gravity commented Nov 22, 2024

So the current Laravel framework has been bumped to portable-ascii ^2.0.2 in 11.33

"voku/portable-ascii": "^2.0.2"

Edit: Just realised Duncan already mentioned that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants