-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ExtensionApp #592
Use ExtensionApp #592
Conversation
@davidbrochart Just letting you know that I subscribed to this PR. I'm happy to help at anytime (review, code, etc.). Ping me if you have any questions. |
Thanks @Zsailer, I think I do need your help at this point. There are three failures for which you might have an idea. Also, with a general review. |
{'Voila': {'open_browser': False}}, | ||
_("Don't open the notebook in a browser after startup.") | ||
), | ||
"standalone": ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this disappeared, but I am not sure how we can detect if we are in 'standalone' mode, do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think this is replaced by load_other_extensions
, which I set to True
because of this issue: jupyter-server/jupyter_server#211
class Voila(ExtensionApp): | ||
extension_name = 'voila' | ||
extension_url = '/voila' | ||
load_other_extensions = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this set to True? This will load jupyterlab/notebook in the future if we run voila in standalone mode, or am I misunderstanding this flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of this bug: jupyter-server/jupyter_server#211
It is fixed now, but not released yet.
Not sure how to fix the |
I think this should be handled by nbclassic. nbclassic will likely need to be a dependency in Voila. It will serve notebook frontend extensions and shim notebook traits appropriately. |
fb35231
to
eea5922
Compare
Just a heads up, you can review notebook changes like this using GitNotebooks. e.g. this pull request https://gitnotebooks.com/voila-dashboards/voila/pull/592 It's free for public repos, so might be helpful for y'all. |
No description provided.