From d2d869c98b0c88276ee1398a8399ec3bff2f0053 Mon Sep 17 00:00:00 2001 From: martinRenou Date: Wed, 9 Oct 2024 19:00:23 +0200 Subject: [PATCH 1/5] Fix CI --- .github/workflows/check-release.yml | 2 +- .github/workflows/packaging.yml | 4 ++-- .github/workflows/ui-tests.yml | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index 6c2d0da54..762c84213 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -27,7 +27,7 @@ jobs: version_spec: next - name: Upload Distributions - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: voila-releaser-dist-${{ github.run_number }} path: .jupyter_releaser_checkout/dist diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml index bc3c1ab07..041973a01 100644 --- a/.github/workflows/packaging.yml +++ b/.github/workflows/packaging.yml @@ -46,7 +46,7 @@ jobs: sha256sum * | tee SHA256SUMS - name: Upload distributions - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: dist ${{ github.run_number }} path: ./dist @@ -76,7 +76,7 @@ jobs: with: python-version: ${{ matrix.python }} architecture: 'x64' - - uses: actions/download-artifact@v2 + - uses: actions/download-artifact@v3 with: name: dist ${{ github.run_number }} path: ./dist diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index 068c76898..27a1c7b11 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -50,7 +50,7 @@ jobs: - name: Upload Playwright Test assets if: always() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: voila-test-assets path: | @@ -58,7 +58,7 @@ jobs: - name: Upload Playwright Benchmark report if: always() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: voila-benchmark-report path: | @@ -66,7 +66,7 @@ jobs: - name: Upload Playwright Test report if: always() - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: voila-test-report path: | From 8c65b2f7083706a9951dac90c71ef9215d97cdff Mon Sep 17 00:00:00 2001 From: martinRenou Date: Wed, 9 Oct 2024 19:05:05 +0200 Subject: [PATCH 2/5] Update setup python --- .github/workflows/main.yml | 2 +- .github/workflows/packaging.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 26712efb1..171296193 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -116,7 +116,7 @@ jobs: - uses: actions/checkout@v2 - name: Set up Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml index 041973a01..5a8eea0d7 100644 --- a/.github/workflows/packaging.yml +++ b/.github/workflows/packaging.yml @@ -72,7 +72,7 @@ jobs: py_cmd: python steps: - name: Install Python - uses: actions/setup-python@v4 + uses: actions/setup-python@v5 with: python-version: ${{ matrix.python }} architecture: 'x64' From 4bb19b5c6bbdb1dc93640275e8914a854d812fb2 Mon Sep 17 00:00:00 2001 From: martinRenou Date: Wed, 9 Oct 2024 19:10:41 +0200 Subject: [PATCH 3/5] Try --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 171296193..bf0e30fe8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -70,7 +70,7 @@ jobs: strategy: fail-fast: false matrix: - os: [macos-12] + os: [macos] python_version: ['3.8', '3.9', '3.10', '3.11'] steps: From 0a0ceb5a5f8d8261f62a168e2e0bb5b3ff3bda17 Mon Sep 17 00:00:00 2001 From: martinRenou Date: Wed, 9 Oct 2024 19:11:35 +0200 Subject: [PATCH 4/5] Try something else --- .github/workflows/packaging.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml index 5a8eea0d7..50f9f021d 100644 --- a/.github/workflows/packaging.yml +++ b/.github/workflows/packaging.yml @@ -75,7 +75,6 @@ jobs: uses: actions/setup-python@v5 with: python-version: ${{ matrix.python }} - architecture: 'x64' - uses: actions/download-artifact@v3 with: name: dist ${{ github.run_number }} From 854ce0b38e77c8bb3cde85fb2df8781402920e03 Mon Sep 17 00:00:00 2001 From: martinRenou Date: Wed, 9 Oct 2024 19:17:13 +0200 Subject: [PATCH 5/5] Auto cancel workflows for new commits --- .github/workflows/build.yml | 4 ++++ .github/workflows/check-release.yml | 4 ++++ .github/workflows/main.yml | 4 ++++ .github/workflows/packaging.yml | 4 ++++ .github/workflows/ui-tests.yml | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8de6e8ccc..85a824ccd 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -10,6 +10,10 @@ on: schedule: - cron: '0 2 * * 1-5' # run on weekdays at 2:00am UTC +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + jobs: build: runs-on: ubuntu-latest diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml index 762c84213..5fe3600ae 100644 --- a/.github/workflows/check-release.yml +++ b/.github/workflows/check-release.yml @@ -7,6 +7,10 @@ on: branches: - main +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + permissions: contents: write diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bf0e30fe8..a686d40ea 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -10,6 +10,10 @@ on: schedule: - cron: '0 2 * * 1-5' # run on weekdays at 2:00am UTC +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + jobs: test-linux: runs-on: ${{ matrix.os }} diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml index 50f9f021d..8a615e083 100644 --- a/.github/workflows/packaging.yml +++ b/.github/workflows/packaging.yml @@ -8,6 +8,10 @@ on: branches: - '*' +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + env: PIP_DISABLE_PIP_VERSION_CHECK: 1 diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index 27a1c7b11..7b01e6def 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -2,6 +2,10 @@ name: UI Tests on: [push, pull_request] +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + jobs: ui-tests: name: Visual Regression