Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of the base_url in 0.3.0a0 #992

Closed
jtpio opened this issue Oct 5, 2021 · 1 comment · Fixed by #993
Closed

Handling of the base_url in 0.3.0a0 #992

jtpio opened this issue Oct 5, 2021 · 1 comment · Fixed by #993
Labels
bug Something isn't working
Milestone
0.3.0

Comments

@jtpio
Copy link
Member

jtpio commented Oct 5, 2021

Description

Testing 0.3.0a0 on Binder gives the following:

image

Here we see that we are trying the fetch require.min.js without taking into account the base url.

Reproduce

Expected behavior

Context

This works fine with 0.2.16 on Binder, so probably an issue introduced in #936 (cc @trungleduc)

  • voila version: 0.3.0a0
  • Operating System and version: Ubuntu 20.04
  • Browser and version: Chromium / Firefox
@jtpio jtpio added the bug Something isn't working label Oct 5, 2021
@jtpio jtpio added this to the 0.3.0 milestone Oct 5, 2021
@trungleduc
Copy link
Member

I will look after this bug.

@trungleduc trungleduc mentioned this issue Oct 5, 2021
Merged
@jtpio jtpio closed this as completed in #993 Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Fix wrong base_url trungleduc/voila
2 participants
@jtpio @trungleduc