Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voila.ip option not in documentation and -h help string #447

Open
tomanizer opened this issue Oct 25, 2019 · 6 comments
Open

Voila.ip option not in documentation and -h help string #447

tomanizer opened this issue Oct 25, 2019 · 6 comments

Comments

@tomanizer
Copy link

Follow up from #443

Viola has an option to serve the dashboard on a public interface using the voila.ip parameter.
However this is not mentioned in the documentation which only refers to serving on localhost,
It is also not referenced in the voila help string -h..
-h only refers to the port, but not the IP address.

The option should be added to the documentation and the help string.

@tomanizer tomanizer changed the title Voila.ip option not in documentation ind -h help string Voila.ip option not in documentation and -h help string Oct 25, 2019
@SylvainCorlay
Copy link
Member

Btw it is spelled voila ;)

@jtpio
Copy link
Member

jtpio commented Oct 29, 2019

Thanks @tomanizer for opening a new issue to keep track of this.

Would you like to open a PR to add it to the documentation?

@tomanizer
Copy link
Author

Yes. Let me try to add this.

@wolfv
Copy link
Member

wolfv commented Jan 13, 2020

It could also be good to expose --Voila.ip as --ip as in JupyterLab.

@jtpio
Copy link
Member

jtpio commented Jan 14, 2020

It could also be good to expose --Voila.ip as --ip as in JupyterLab.

This should come "for free" with #492.

In the meantime we could add an alias here:

voila/voila/app.py

Lines 119 to 129 in e97044f

aliases = {
'port': 'Voila.port',
'static': 'Voila.static_root',
'strip_sources': 'VoilaConfiguration.strip_sources',
'autoreload': 'Voila.autoreload',
'template': 'VoilaConfiguration.template',
'theme': 'VoilaConfiguration.theme',
'base_url': 'Voila.base_url',
'server_url': 'Voila.server_url',
'enable_nbextensions': 'VoilaConfiguration.enable_nbextensions'
}

@tharwan
Copy link

tharwan commented Jan 6, 2022

Just came here to say that this is related to the recent bugfix in 0.3.0 which changes the default behaviour and this option is missing to change it back to the old behaviour.

Edit: I needed to set this option in order for the docker deployment to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants