-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VoilaApp inherit from JupyterApp? #245
Comments
I think that we should wait for the ExtensionApp system to be in jupyter_server and have voila be an ExtensionApp. |
Anything I can do to move this along? :) |
@vidartf I am fine with the current state of the PR. How about we merge it today. I just leave it open so that you have a chance to give it a look? One thought that relates to voila:
|
@SylvainCorlay Regarding your third point: Which bit is it that will end up loading the different server extensions? The
|
See #270 |
Won't do, #270 is better |
We now inherit from Application, should we inherit from JupyterApp (see discussion in #216) , or can jupyter_server help out here?
The text was updated successfully, but these errors were encountered: