Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of ADMIN_GITHUB_TOKEN for releasing with the Jupyter Releaser #1449

Closed
jtpio opened this issue Mar 11, 2024 · 4 comments · Fixed by #1453
Closed

Remove usage of ADMIN_GITHUB_TOKEN for releasing with the Jupyter Releaser #1449

jtpio opened this issue Mar 11, 2024 · 4 comments · Fixed by #1453

Comments

@jtpio
Copy link
Member

jtpio commented Mar 11, 2024

The Jupyter Releaser updated its example workflows to use a GitHub App instead of relying on the ADMIN_GITHUB_TOKEN: https://github.com/jupyter-server/jupyter_releaser/blob/89be0fbdc13f47011c95a870218c18d94c4f193b/example-workflows/publish-release.yml#L24

For reference this is already in use in some other Jupyter projects, for example Jupyter Server: https://github.com/jupyter-server/jupyter_server/blob/69361eeb2702572faca6e6cc8ac1003e393eb5aa/.github/workflows/publish-release.yml#L24

We could start doing the same for the repos under the voila-dashboards organization, following the guide: https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo_from_repo.html#checklist-for-adoption

@jtpio
Copy link
Member Author

jtpio commented Mar 27, 2024

Opened PRs on several repos currently using the releaser:

@martinRenou @trungleduc are there any other repos in the voila-dashboards org using the releaser?

@trungleduc
Copy link
Member

Thanks @jtpio for working on it, https://github.com/voila-dashboards/voila-topbar still uses the admin token

@jtpio
Copy link
Member Author

jtpio commented Mar 27, 2024

OK thanks, just opened voila-dashboards/voila-topbar#11

@jtpio
Copy link
Member Author

jtpio commented Mar 27, 2024

ADMIN_GITHUB_TOKEN has now been removed from the org secrets.

The new credentials for the GitHub app have been added to the Jupyter 1Password (cc @martinRenou as SSC rep for Voila)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants