Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 3.6 and traitlets 4 from CI test #1027

Closed
trungleduc opened this issue Nov 15, 2021 · 5 comments · Fixed by #1060
Closed

Drop python 3.6 and traitlets 4 from CI test #1027

trungleduc opened this issue Nov 15, 2021 · 5 comments · Fixed by #1060
Labels
enhancement New feature or request testing

Comments

@trungleduc
Copy link
Member

Voila depends heavily on nbconvert and nbconvert required minimum python 3.7 and traitlets 5 since version 6.1.0. Should we drop the configuration for testing python 3.6 and add the test for python 3.10?
@trungleduc trungleduc added enhancement New feature or request testing labels Nov 15, 2021
@trungleduc trungleduc mentioned this issue Nov 17, 2021
Closed
@fhightower fhightower mentioned this issue Dec 8, 2021
Merged
@trungleduc
Copy link
Member Author

@jtpio should we go for it?

@jtpio
Copy link
Member

jtpio commented Dec 9, 2021

I would say yes, especially since nbconvert now requires 3.7+.

Not sure whether it should go in a 0.3.1 just yet though. We might want to wait for the final 3.6 EOL before releasing.

@jtpio
Copy link
Member

jtpio commented Dec 13, 2021

Maybe we could start testing on 3.7 and 3.10 on CI as a first step. I'll open a PR.

@jtpio jtpio mentioned this issue Dec 13, 2021
Merged
3 tasks
@trungleduc
Copy link
Member Author

The latest release of jupyter_server is not compatible with traitlets 4 jupyter-server/jupyter_server#661

@martinRenou martinRenou mentioned this issue Jan 17, 2022
Merged
@martinRenou
Copy link
Member

Remove traitlets 4 test in #1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request testing
Projects
None yet
Milestone
No milestone
3 participants
@jtpio @trungleduc @martinRenou