New package: ncspot-0.11.2

[ram02z]

General

• This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

• I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
• I generally don't use the affected packages but briefly tested this PR

Using the termion as the backend instead of ncurses-rs which doesn't crosscompile. See #23415

[ram02z]

Waiting on #32555, since ncspot 0.9.1 requires Rust 1.55 or later.

[pfr-dev]

Waiting on #32555, since ncspot 0.9.1 requires Rust 1.55 or later.

0.9.3 just got released. I'm following this thread watching for updates. Cheers for your work :)

[0323pin]

FI, @pfr-dev ncspot-0.9.3 requires rust >= 1.56, neither 1.54 or 1.55 will do as edition was bumped to 2021.

[ram02z]

CI failures might be related to librespot-org/librespot#774

Also, why are cross builds taking 2 hours?

[ram02z]

ncspot-0.95 requires rust 1.58.0

See hrkfdn/ncspot#714

[0323pin]

@ram02z Yes but, I can confirm that the patch provide, hrkfdn/ncspot#714 (comment)

allows the build to succeed with rust-1.57.0
I've merged the package on NetBSD yesterday, https://mail-index.netbsd.org/pkgsrc-changes/2022/01/19/msg247190.html

EDIT:

$NetBSD: patch-src_ui_listview.rs,v 1.1 2022/01/19 14:04:45 pin Exp $

Fix build with rust =< 1.58.0
Patch provided by upstream

--- src/ui/listview.rs.orig    2022-01-18 21:10:09.000000000 +0000
+++ src/ui/listview.rs
@@ -85,7 +85,7 @@ impl<I: ListItem> ListView<I> {
 
     pub fn content_height_with_paginator(&self) -> usize {
         let content_len = self.content.read().unwrap().len();
-        log::info!("content len: {content_len}");
+        log::info!("content len: {}", content_len);
 
         // add 1 more row for paginator if we can paginate
         if self.can_paginate() {
@@ -97,7 +97,7 @@ impl<I: ListItem> ListView<I> {
 
     fn can_paginate(&self) -> bool {
         let loaded = self.get_pagination().loaded_content();
-        log::info!("can paginate: {loaded}");
+        log::info!("can paginate: {}", loaded);
         self.get_pagination().max_content().unwrap_or(0) > self.get_pagination().loaded_content()
     }

[ram02z]

@ram02z Yes but, I can confirm that the patch provide, hrkfdn/ncspot#714 (comment)

allows the build to succeed with rust-1.57.0 I've merged the package on NetBSD yesterday, https://mail-index.netbsd.org/pkgsrc-changes/2022/01/19/msg247190.html

Thanks. I saw the patch but I probably won't bump this package until the rust cross build starts working again on Void Linux.

[0323pin]

probably won't bump this package until the rust cross build starts working again on Void Linux.

I haven't tried to cross compile. It will take a few days before the build infrastructure starts to spit-out binaries and to see if the builds are successful on other platforms. I only have access to x86_64 hardware and on it, it builds fine.

[ram02z]

Cross build now works thanks to this snippet #34889 (comment)

[pfr-dev]

trying to update to 0.9.7 from 0.9.0

I took the template and swapped it out for the old one and ran ./xbps-src update-sys but it fails to build zlib-1.2.11_4

=> zlib-1.2.11_4: building [configure] (dependency of pcre) for x86_64...
   [runtime] zlib-1.2.11_4: not found (self, ignored)
=> zlib-1.2.11_4: running do-fetch hook: 00-distfiles ...
=> zlib-1.2.11_4: fetching distfile 'zlib-1.2.11.tar.gz'...
http://www.zlib.net/zlib-1.2.11.tar.gz: Not Found
=> ERROR: zlib-1.2.11_4: failed to fetch zlib-1.2.11.tar.gz.
=> ERROR: xbps-src: failed to build ncspot-0.9.7_1 pkg!

I have zlib-1.2.12_1 currently installed

[abenson]

You need to rebase on master. https://github.com/void-linux/void-packages/blob/master/Manual.md#contributing-via-git

…

On Tue, Apr 5, 2022 at 4:52 AM Dave ***@***.***> wrote: trying to update to 0.9.7 from 0.9.0 I took the template and swapped it out for the old one and ran ./xbps-src update-sys but it fails to build zlib -1.2.11.4 => zlib-1.2.11_4: building [configure] (dependency of pcre) for x86_64... [runtime] zlib-1.2.11_4: not found (self, ignored) => zlib-1.2.11_4: running do-fetch hook: 00-distfiles ... => zlib-1.2.11_4: fetching distfile 'zlib-1.2.11.tar.gz'...http://www.zlib.net/zlib-1.2.11.tar.gz: Not Found => ERROR: zlib-1.2.11_4: failed to fetch zlib-1.2.11.tar.gz. => ERROR: xbps-src: failed to build ncspot-0.9.7_1 pkg! — Reply to this email directly, view it on GitHub <#33600 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABXP5OLC67FQBM2PEXSWP3VDQEMDANCNFSM5GET4EDA> . You are receiving this because you commented.Message ID: ***@***.***>

[apprehensions]

🧁

[github-actions]

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

[ram02z]

Bump (Will update to 0.11.2 tomorrow).

[atweiden]

https://github.com/hrkfdn/ncspot/blob/main/README.md#on-linux

cover feature should entail depends+=ueberzug for displaying cover art at runtime.

clipboard is a default feature of the crate, hence libxcb may be a runtime dep. I haven’t tested, though.

[classabbyamp]

libxcb is detected

[classabbyamp]

see 009bac3

[0323pin]

@classabbyamp See https://github.com/seebye/ueberzug

[classabbyamp]

ok