From 346f4dacd00a97fdc043b2c691927cb47eef8457 Mon Sep 17 00:00:00 2001 From: Pirmin Vogel Date: Thu, 9 May 2024 15:33:16 +0200 Subject: [PATCH] [sival] Mark fixed entropy complex tests as unbroken in ROM_EXT These tests are all working in ROM_EXT on master and earlgrey_es_sival now that we've fixed the underlying keymgr issue. For details, see https://github.com/lowRISC/opentitan/issues/22819#issuecomment-2095648654 This is related to lowRISC/OpenTitan#21706 and lowRISC/OpenTitan#22140. Signed-off-by: Pirmin Vogel --- sw/device/tests/BUILD | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/sw/device/tests/BUILD b/sw/device/tests/BUILD index ee6207ae8d5f0f..2132a386688e9a 100644 --- a/sw/device/tests/BUILD +++ b/sw/device/tests/BUILD @@ -915,12 +915,11 @@ opentitan_test( opentitan_test( name = "csrng_edn_concurrency_test", srcs = ["csrng_edn_concurrency_test.c"], - broken = cw310_params(tags = ["broken"]), exec_env = dicts.add( EARLGREY_TEST_ENVS, { "//hw/top_earlgrey:fpga_cw310_sival": None, - "//hw/top_earlgrey:fpga_cw310_sival_rom_ext": "broken", + "//hw/top_earlgrey:fpga_cw310_sival_rom_ext": "None", "//hw/top_earlgrey:silicon_creator": None, "//hw/top_earlgrey:silicon_owner_sival_rom_ext": "silicon_owner", "//hw/top_earlgrey:silicon_owner_prodc_rom_ext": "silicon_owner", @@ -955,14 +954,11 @@ opentitan_test( opentitan_test( name = "csrng_kat_test", srcs = ["csrng_kat_test.c"], - broken = cw310_params(tags = ["broken"]), exec_env = dicts.add( EARLGREY_TEST_ENVS, EARLGREY_SILICON_OWNER_ROM_EXT_ENVS, { "//hw/top_earlgrey:silicon_creator": None, - # FIXME broken in sival ROM_EXT, remove this line when fixed. See #21706. - "//hw/top_earlgrey:fpga_cw310_sival_rom_ext": "broken", }, ), silicon = silicon_params( @@ -981,14 +977,11 @@ opentitan_test( opentitan_test( name = "csrng_smoketest", srcs = ["csrng_smoketest.c"], - broken = cw310_params(tags = ["broken"]), exec_env = dicts.add( EARLGREY_TEST_ENVS, EARLGREY_SILICON_OWNER_ROM_EXT_ENVS, { "//hw/top_earlgrey:silicon_creator": None, - # TODO(#22140): remove this lined when fixed. - "//hw/top_earlgrey:fpga_cw310_sival_rom_ext": "broken", }, ), silicon = silicon_params(tags = ["broken"]), @@ -1111,14 +1104,11 @@ opentitan_test( name = "edn_kat", srcs = ["edn_kat.c"], # Remove this line when fixed. - broken = cw310_params(tags = ["broken"]), exec_env = dicts.add( EARLGREY_TEST_ENVS, EARLGREY_SILICON_OWNER_ROM_EXT_ENVS, { "//hw/top_earlgrey:silicon_creator": None, - # FIXME broken in sival ROM_EXT, remove this line when fixed. See #21706. - "//hw/top_earlgrey:fpga_cw310_sival_rom_ext": "broken", }, ), verilator = verilator_params(