Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support name resolution for renamed running containers #4375

Closed
anchal-agrawal opened this issue Mar 23, 2017 · 6 comments
Closed

Support name resolution for renamed running containers #4375

anchal-agrawal opened this issue Mar 23, 2017 · 6 comments
Assignees
Labels
area/docker Support for the Docker operations component/portlayer/network impact/test/integration/enable The test is associated with a disabled integration test priority/p2 source/customer Reported by a customer, directly or via an intermediary team/container

Comments

@anchal-agrawal
Copy link
Contributor

anchal-agrawal commented Mar 23, 2017

User Statement:

As a user of VIC, I should be able to rename a running container (c1) and use the new name to create a link to or ping from another container (c2) without restarting container c1.

Details:

We need to update the alias and any name resolution metadata for the container during its rename operation. This is a follow-up of #4082, whose scope includes support for name resolution for containers that are restarted after renaming them, and containers that are created, renamed and then started. Renaming a running container will work after #4082 is closed, but name resolution for it won't.

Acceptance Criteria:

Passing tests for the following use cases:

# Container link
$ docker run -dit --name c1 busybox
$ docker rename c1 c11
$ docker run --link c11:c11alias busybox ping -c2 c11alias
...
2 packets transmitted, 2 packets received...

# Ping by name for containers on the same network
$ docker run -dit --name c1 busybox
$ docker rename c1 c11
$ docker run busybox ping -c2 c11
...
2 packets transmitted, 2 packets received...
@anchal-agrawal
Copy link
Contributor Author

Need an estimate from @hmahmood - I suspect this will be no less than a 3.

@anchal-agrawal anchal-agrawal added the impact/test/integration/enable The test is associated with a disabled integration test label Mar 24, 2017
@anchal-agrawal
Copy link
Contributor Author

There's an integration test in Group1-Docker-Commands/1-36-Docker-Rename tagged against this issue.

@hickeng hickeng added source/customer Reported by a customer, directly or via an intermediary priority/p2 and removed priority/p4 labels Sep 7, 2017
@hickeng
Copy link
Member

hickeng commented Sep 7, 2017

@mdubya66 This has been found by @smaliakkal - the necessity for rename in this specific scenario would be eliminated, and come with a performance improvement and complexity reduction, by adding naming convention support for containerVMs. The epic #773 references the naming conventions, both for inventory folders and cVMs, but I didn't find a dedicated issue for the cVM specifically.

@renmaosheng
Copy link
Contributor

closing per previous comment, please reopen if you think otherwise.

@renmaosheng
Copy link
Contributor

we need to change the CI script if this is closed, reopen it and close it again once the test passed.

@luwang-vmware
Copy link
Contributor

Update the CI scripts and get PASS https://ci-vic.vmware.com/vmware/vic/20826. Close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker Support for the Docker operations component/portlayer/network impact/test/integration/enable The test is associated with a disabled integration test priority/p2 source/customer Reported by a customer, directly or via an intermediary team/container
Projects
None yet
Development

No branches or pull requests

5 participants