Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port-layer: support in memory data migration for container configuration #3610

Closed
emlin opened this issue Jan 17, 2017 · 4 comments
Closed

Comments

@emlin
Copy link
Contributor

emlin commented Jan 17, 2017

As a user, I want to upgrade VCH to a newer version, and leave existing container in old version. If I need newer version's container, I will recreate new container, which should be in newer version. So that I get similar workflow with vanilla docker.

@emlin
Copy link
Contributor Author

emlin commented Jan 18, 2017

In this case, Portlayer need to support backward compatibility after VCH is updated.
Cause old container is not updated, the newer configuration can only be consumed in portlayer memory, instead of write back to container configuration.

@mhagen-vmware mhagen-vmware removed this from the Sprint 1 milestone Jan 31, 2017
@emlin
Copy link
Contributor Author

emlin commented Feb 15, 2017

move back to high cause this need to be done in next sprint

@andrewtchin andrewtchin self-assigned this Feb 15, 2017
@mhagen-vmware mhagen-vmware added this to the Sprint 3 milestone Feb 15, 2017
@matthewavery matthewavery self-assigned this Feb 22, 2017
@andrewtchin andrewtchin removed their assignment Feb 22, 2017
@matthewavery
Copy link
Contributor

Upon talking more with @emlin it looks like we must check for migration when the container cache is synced and when new handles are created. Additionally we must abandon configs that have actual changes during the commit phase. Which means that on older versioned containers we will probably only support start and stop operations for controlling the container runtime. The spirit of this ticket is that we need to make sure that all in memory ExecConfigs must be checked for migration and migrated if possible. But we must also preserve the truth of what the containerVM is in vsphere since that is the operation model. If we allow a commit to a container of an older version and its config changes in vsphere there is a good possibility that the older container may be broken forever.

@matthewavery
Copy link
Contributor

Passing this on to @emlin. The initial pr I opened for this ticket is now referenced here and closed. We have catalogued the additional changes needed and decided that this change is less trivial than previously thought. @emlin has my notes on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment