vdk-core: vdk_exception hook exit code fix #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of StandaloneDataJob, the vdk_exception hook was always returning exit code 1, no matter if exception was successfully handled or not. Also, in case of empty job, vdk_exception was not triggered. Fixed the StandaloneDataJob return status to 0 in case exception was successfully handled. Fixed the case with ClickException not propagating to vdk_exception hook. Testing Done: run tests locally; did verify manually that an empty job does evaluate vdk_exception hook, and in case exception is successfully handled then the data job exit code is 0. Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of StandaloneDataJob, the vdk_exception hook was always
returning exit code 1, no matter if exception was successfully handled
or not. Also, in case of empty job, vdk_exception was not triggered.
Fixed the StandaloneDataJob return status to 0 in case exception was
successfully handled. Fixed the case with ClickException not propagating
to vdk_exception hook.
Testing Done: run tests locally; did verify manually that an empty job
does evaluate vdk_exception hook, and in case exception is successfully
handled then the data job exit code is 0.
Signed-off-by: ikoleva [email protected]