Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vm update storage profile #580

Merged
merged 28 commits into from
Nov 10, 2020
Merged

Vm update storage profile #580

merged 28 commits into from
Nov 10, 2020

Conversation

vbauzys
Copy link
Contributor

@vbauzys vbauzys commented Oct 22, 2020

Ref:#546

change allows to update VM storage profile. Before storage profile was used only on create.

vbauzys added 11 commits August 19, 2020 16:56
@vbauzys
bump to right govcd version
f4e89ae
@vbauzys
Merge branch 'master' of github.com:vmware/terraform-provider-vcd
ba68d03 
# Conflicts:
#	go.mod
#	go.sum
#	vendor/modules.txt
@vbauzys
Merge branch 'master' of github.com:vmware/terraform-provider-vcd
d7570ff 
# Conflicts:
#	go.mod
#	go.sum
@vbauzys
git push origin master
54fd496 
Merge branch 'master' of github.com:vmware/terraform-provider-vcd
@vbauzys
git push origin master
a52d5a2 
Merge branch 'master' of github.com:vmware/terraform-provider-vcd
@vbauzys
git push origin master
12c9d27 
Merge branch 'master' of github.com:vmware/terraform-provider-vcd
@vbauzys
git push origin master
ba21c6f 
Merge branch 'master' of github.com:vmware/terraform-provider-vcd
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/terr…
004d64b 
…aform-provider-vcd
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/terr…
5ac6eb7 
…aform-provider-vcd
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/terr…
856a742 
…aform-provider-vcd
@vbauzys
add impl for VM to able update storage profile
8f62521
@vbauzys vbauzys requested review from lvirbalas, dataclouder and Didainius and removed request for lvirbalas October 22, 2020 13:15
Didainius
Didainius reviewed Oct 23, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No biggie. A few small comments.

vcd/resource_vcd_vapp_vm.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_vm_hot_updates_test.go Show resolved Hide resolved
Didainius
Didainius reviewed Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few queries and checks

vcd/resource_vcd_vapp_vm.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_vm.go Outdated Show resolved Hide resolved
vcd/resource_vcd_vapp_vm_hot_updates_test.go Outdated Show resolved Hide resolved
vcd/config_test.go Outdated Show resolved Hide resolved
@vbauzys
small improvement
e1c4a43
@vbauzys
git push origin masterMerge branch 'master' of github.com:vmware/terr…
e0aa7db 
…aform-provider-vcd
@vbauzys
Merge branch 'master' into vm_update_storage_profile
c9d7f0d 
# Conflicts:
#	.travis.yml
#	go.sum
#	vendor/github.com/vmware/go-vcloud-director/v2/govcd/vm.go
#	vendor/github.com/vmware/go-vcloud-director/v2/types/v56/vm_types.go
#	vendor/modules.txt
@vbauzys
bump govcd
e96c43b
@vbauzys
cleanup
a5a64ae
@vbauzys
improve test
7e286d6
lvirbalas
lvirbalas approved these changes Nov 6, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Didainius
Didainius approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. make testvm passed

@vbauzys vbauzys merged commit f66d0ce into vmware:master Nov 10, 2020
@lvirbalas lvirbalas mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbauzys @lvirbalas @dataclouder @Didainius @vmwclabot