Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in latest go-vcloud-director SDK with 10.1 fixes #489

Merged
merged 18 commits into from
Apr 10, 2020
Merged

Pull in latest go-vcloud-director SDK with 10.1 fixes #489

merged 18 commits into from
Apr 10, 2020

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Apr 7, 2020 •
edited
Loading

This PR just bumps go-vcloud-director SDK to the latest one so that 10.1 related fixes are in place.
It also covers the following:

@Didainius Didainius self-assigned this Apr 7, 2020
lvirbalas
lvirbalas approved these changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's get this in!

dataclouder
dataclouder approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost added size/L documentation and removed size/M labels Apr 9, 2020
@Didainius Didainius merged commit b1ef030 into vmware:master Apr 10, 2020
@Didainius Didainius deleted the test-pvdc-nsxt-fix branch April 10, 2020 07:56
@Didainius Didainius mentioned this pull request Apr 15, 2020
Merged
Didainius added a commit that referenced this pull request Apr 15, 2020
@Didainius
Add vCD 10.1 vcd_org_vdc fix note to changelog (#494)
7902655 
* Add vCD 10.1 vcd_org_vdc fix note to changelog which was actually fixed with #489 by pulling in go-vcloud-director SDK version vmware/go-vcloud-director#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbauzys vbauzys vbauzys approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@Didainius Didainius

Labels
dependencies documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vApp may need powering off to avoid vApp network removal errors
4 participants
@Didainius @lvirbalas @dataclouder @vbauzys